feat(component groups): rename various components#776
Merged
thatblindgeye merged 5 commits intopatternfly:mainfrom Sep 24, 2024
Merged
feat(component groups): rename various components#776thatblindgeye merged 5 commits intopatternfly:mainfrom
thatblindgeye merged 5 commits intopatternfly:mainfrom
Conversation
This was
linked to
issues
Sep 23, 2024
Comment on lines
+81
to
+82
| // These rules rename components. These components also have mods renaming props on them. | ||
| // -> we have to rename the component after the rules renaming props finish |
Collaborator
There was a problem hiding this comment.
Rather than this, could we update the rename props rule(s) for these components to target either the old or new name?
adamviktora
force-pushed
the
component-groups-rename-components
branch
from
6c111f1 to
dbfc10b
Compare
thatblindgeye
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #769, #772, #773
renameComponenthelper to update node name when default import matches the component name, e.g.:import InvalidObject from '@patternfly/react-component-groups/dist/cjs/InvalidObject/index'; <InvalidObject />will update toimport MissingPage from '@patternfly/react-component-groups/dist/cjs/MissingPage/index'; <MissingPage data-codemods />